valence icon indicating copy to clipboard operation
valence copied to clipboard

The `Text` struct is too large.

Open rj00a opened this issue 2 years ago • 1 comments

cargo clippy often complains that std::mem::size_of::<Text>() is too large. There are a few things that should be done.

  • Stop using Cow<'static, str> everywhere and just use String. We can reintroduce it later if it turns out to be important.
  • Get rid of the Option<bool>s by manually implementing Serialize and Deserialize. Use a bitset with two bits per Option<bool>.

rj00a avatar Sep 04 '22 22:09 rj00a

I'd like to take a stab at this.

dyc3 avatar Sep 06 '22 14:09 dyc3