valarnin

Results 65 comments of valarnin

Custom triggers do not change the network log file. Maybe your cactbot overlay is pointing to an out-of-date cactbot install? You could try either of the following: - Remove the...

Sorry, I had forgotten that I had played around with fixes between when I originally ran the first trace and when I re-did the analysis for opening this issue. Updated...

I think this was rather caused by #4334, since oopsy shouldn't be looking at popup-text.ts at all. Probably if oopsy detects a match against `wipeEndEcho` it should just clear instead...

I think it's typescript vs javascript linting that's the problem. Linting an arbitrarily large js file seems fine, linting a single line of typescript breaks it.

I went ahead and opened the issue on the OP github https://github.com/ngld/OverlayPlugin/issues/263

> Additionally, this adds a trigger for left/right movement depending on boss movement ***(the logic on this could use a double-check)***. Emphasis added. Probably I got left vs right backwards...

I tested this in raidemulator and can't reproduce, for at least the `TEA Contact Prohibition` trigger. ![image](https://user-images.githubusercontent.com/6119598/120840593-74011300-c538-11eb-9550-5750a914a9bf.png) ![image](https://user-images.githubusercontent.com/6119598/120840786-a7dc3880-c538-11eb-9953-b1681d0f379a.png) ![image](https://user-images.githubusercontent.com/6119598/120840701-909d4b00-c538-11eb-8588-5e03d2e2fd2e.png)

Probably two checks: 1. If the canonical path (via `File.GetFullPath` or some other mechanism) does not case-insensitive match the original path, don't read those files (prevent directory traversal and such)...

I believe that the first issue isn't KR-specific, it's something that happens randomly when switching from one encounter to another where the jump to the beginning of the pull isn't...

I maybe mis-explained? When raidemulator initially parses a network line, it generates the equivalent non-network-line version, aka `convertedLine`. This generation was updated to match 6.x, so it's always generating the...