Daniel Valadas

Results 428 comments of Daniel Valadas

This might be auto-closed or bumped once https://github.com/dnnsoftware/Dnn.Platform/pull/6565 is merged

There was quite some changes to how the react-output-target works. I don't use React and don't have much time, anyone interested on fixing this pr?

I totally agree that 5 and 6 is the job of the developer + with http2 and protocol level compression is often of very minimal impact.

A fluent API would also be cool... ```cs _ourNewManager .RegisterScript() .FromName("jquery") // vs .FromSrc("path/to/file") .WithVersion(3.7.1) .SetAsync() // which defaults to true, but could be .SetAsync(true) or .SetAsync(false) .SetRel(RelOption.ModulePreload) .SetType(ScriptTypeOption.Module) ```...

Yep, with a fluent API we could have .AddAttributes(Dictionary attributes) or .AddAttribute(string name, string value) or something like that

Awesome, I'll try to get my review in this weekend...

> > MVC Pipeline and CSP are 2 big ticket items and bringing both in the same PR makes putthing this in a reviewable state hard IMO. The goal of...

> > MVC Pipeline and CSP are 2 big ticket items and bringing both in the same PR makes putthing this in a reviewable state hard IMO. The goal of...