VLS is not being closed automatically by GNOME Builder

[naipotato]

Describe the bug If I open a project in GNOME Builder and then I close the project, VLS seems to not being closed. So if I open other project or the same, a new VLS instance is openned, resulting in 2 instances: one being used and the other just being there, consuming RAM.

Software OS and version (e.g. Ubuntu 20.04): Fedora 32 (Workstation Edition) Code editor (e.g. VSCode): GNOME Builder Vala Language Server (e.g. git commit, or PPA/AUR version): f07adf75884a7143bce70342afbc4a334b50defd Vala version (valac --version): 0.48.2

To Reproduce Source code repo: any repo, it happens with any Vala project.

Steps to reproduce the behavior:

1. Open GNOME Builder
2. Open a Vala project
3. Wait until Vala Language Server is initialized
4. Close project
5. Open another or the same
6. Check System Monitor

[esodan]

As far as I can see VLS doesn't support shutdown method:

$ meson test vls-initialization --gdb
ninja: Entering directory `/home/esodan/Projects/gvls/build'
[1/35] Generating version.vala with a custom command
fatal: No se encontraron nombres, no se puede describir nada.
Reading symbols from /home/esodan/Projects/gvls/build/tests/vls/vls-initialization...
(gdb) r
Starting program: /home/esodan/Projects/gvls/build/tests/vls/vls-initialization 
[Depuración de hilo usando libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
# random seed: R02S1d462f52acf3946d9186c998b81937b1
1..1
# Start of gvls tests
# Start of lsp tests
# Start of stdio tests
[Detaching after fork from child process 37562]
[Nuevo Thread 0x7ffff37d0640 (LWP 37563)]
# MESSAGE: test-vls-initialization.vala:65: Initialize Server
** Message: 07:56:42.988: test-vls-initialization.vala:65: Initialize Server
[Nuevo Thread 0x7ffff2f30640 (LWP 37565)]
# GLib-GIO-DEBUG: _g_io_module_get_default: Found default implementation gvfs (GDaemonVfs) for ‘gio-vfs’
# jsonrpc-output-stream-MESSAGE: >>> {'method': <'initialize'>, 'jsonrpc': <'2.0'>, 'id': <int64 1>, 'params': <{'processId': <int64 1>, 'rootUri': <'file:///home/esodan/Projects/gvls/tests'>, 'initializationOptions': <{'autoConfigure': <false>, 'defaultNamespaces': <true>, 'defaultVapiDirs': <false>, 'scanWorkspace': <true>, 'addUsingNamespaces': <false>, 'mesonBuildSystem': <true>, 'files': <@av []>, 'packages': <@av []>, 'options': <@av []>, 'valaArgs': <@av []>, 'initialized': <true>, 'targets': <@av []>}>, 'capabilities': <{'workspace': <{'applyEdit': <false>, 'workspaceEdit': <{'documentChanges': <false>, 'resourceOperations': <[<<'create'>>, <<'rename'>>, <<'delete'>>]>}>, 'didChangeConfiguration': <{'dynamicRegistration': <false>}>, 'didChangeWhatchedFile': <{'dynamicRegistration': <false>}>, 'symbol': <{'dynamicRegistration': <false>, 'symbolKind': <{'valueSet': <[<int64 0>, <int64 3>, <int64 5>, <int64 6>, <int64 7>, <int64 8>, <int64 10>, <int64 13>, <int64 14>, <int64 15>, <int64 16>, <int64 17>, <int64 22>, <int64 23>]>}>}>, 'executeCommand': <{'dynamicRegistration': <false>}>, 'workspaceFolders': <false>, 'configuration': <true>}>, 'textDocument': <{'synchronization': <{'dynamicRegistration': <false>, 'willSave': <false>, 'willSaveWaitUntil': <false>, 'didSave': <true>}>, 'completion': <{'dynamicRegistration': <false>, 'completionItem': <{'snippetSupport': <false>, 'commitCharactersSupport': <true>, 'documentationFormat': <[<<'plaintext'>>, <<'markdown'>>]>, 'deprecatedSupport': <false>, 'preselectSupport': <false>}>, 'completionItemKind': <{'valueSet': <[<int64 1>, <int64 2>, <int64 5>, <int64 6>, <int64 7>, <int64 8>, <int64 10>, <int64 13>, <int64 14>, <int64 22>]>}>, 'contextSupport': <false>}>, 'hover': <{'dynamicRegistration': <false>, 'contentFormat': <[<<'markdown'>>]>}>, 'signatureHelp': <{'dynamicRegistration': <false>}>, 'references': <{'dynamicRegistration': <false>}>, 'documentHighlight': <{'dynamicRegistration': <false>}>, 'documentSymbol': <{'dynamicRegistration': <false>, 'symbolKind': <{'valueSet': <[<int64 3>, <int64 5>, <int64 6>, <int64 8>, <int64 10>, <int64 11>, <int64 13>, <int64 15>, <int64 23>, <int64 22>]>}>, 'hierarchicalDocumentSymbolSupport': <true>}>, 'formatting': <{'dynamicRegistration': <false>}>, 'rangeFormatting': <{'dynamicRegistration': <false>}>, 'onTypeFormatting': <{'dynamicRegistration': <false>}>, 'definition': <{'dynamicRegistration': <false>}>, 'typeDefinition': <{'dynamicRegistration': <false>}>, 'implementation': <{'dynamicRegistration': <false>}>, 'codeAction': <{'dynamicRegistration': <false>}>, 'codeLens': <{'dynamicRegistration': <false>}>, 'documentLink': <{'dynamicRegistration': <false>}>, 'colorProvider': <{'dynamicRegistration': <false>}>, 'rename': <{'dynamicRegistration': <false>, 'prepareSupport': <false>}>, 'publishDiagnostics': <{'relatedInformation': <false>}>, 'foldingRange': <{'dynamicRegistration': <false>, 'rangeLimit': <int64 0>, 'lineFoldingOnly': <false>}>}>}>, 'workspaceFolders': <@av []>}>}
jsonrpc-output-stream-Message: 07:56:43.009: >>> {'method': <'initialize'>, 'jsonrpc': <'2.0'>, 'id': <int64 1>, 'params': <{'processId': <int64 1>, 'rootUri': <'file:///home/esodan/Projects/gvls/tests'>, 'initializationOptions': <{'autoConfigure': <false>, 'defaultNamespaces': <true>, 'defaultVapiDirs': <false>, 'scanWorkspace': <true>, 'addUsingNamespaces': <false>, 'mesonBuildSystem': <true>, 'files': <@av []>, 'packages': <@av []>, 'options': <@av []>, 'valaArgs': <@av []>, 'initialized': <true>, 'targets': <@av []>}>, 'capabilities': <{'workspace': <{'applyEdit': <false>, 'workspaceEdit': <{'documentChanges': <false>, 'resourceOperations': <[<<'create'>>, <<'rename'>>, <<'delete'>>]>}>, 'didChangeConfiguration': <{'dynamicRegistration': <false>}>, 'didChangeWhatchedFile': <{'dynamicRegistration': <false>}>, 'symbol': <{'dynamicRegistration': <false>, 'symbolKind': <{'valueSet': <[<int64 0>, <int64 3>, <int64 5>, <int64 6>, <int64 7>, <int64 8>, <int64 10>, <int64 13>, <int64 14>, <int64 15>, <int64 16>, <int64 17>, <int64 22>, <int64 23>]>}>}>, 'executeCommand': <{'dynamicRegistration': <false>}>, 'workspaceFolders': <false>, 'configuration': <true>}>, 'textDocument': <{'synchronization': <{'dynamicRegistration': <false>, 'willSave': <false>, 'willSaveWaitUntil': <false>, 'didSave': <true>}>, 'completion': <{'dynamicRegistration': <false>, 'completionItem': <{'snippetSupport': <false>, 'commitCharactersSupport': <true>, 'documentationFormat': <[<<'plaintext'>>, <<'markdown'>>]>, 'deprecatedSupport': <false>, 'preselectSupport': <false>}>, 'completionItemKind': <{'valueSet': <[<int64 1>, <int64 2>, <int64 5>, <int64 6>, <int64 7>, <int64 8>, <int64 10>, <int64 13>, <int64 14>, <int64 22>]>}>, 'contextSupport': <false>}>, 'hover': <{'dynamicRegistration': <false>, 'contentFormat': <[<<'markdown'>>]>}>, 'signatureHelp': <{'dynamicRegistration': <false>}>, 'references': <{'dynamicRegistration': <false>}>, 'documentHighlight': <{'dynamicRegistration': <false>}>, 'documentSymbol': <{'dynamicRegistration': <false>, 'symbolKind': <{'valueSet': <[<int64 3>, <int64 5>, <int64 6>, <int64 8>, <int64 10>, <int64 11>, <int64 13>, <int64 15>, <int64 23>, <int64 22>]>}>, 'hierarchicalDocumentSymbolSupport': <true>}>, 'formatting': <{'dynamicRegistration': <false>}>, 'rangeFormatting': <{'dynamicRegistration': <false>}>, 'onTypeFormatting': <{'dynamicRegistration': <false>}>, 'definition': <{'dynamicRegistration': <false>}>, 'typeDefinition': <{'dynamicRegistration': <false>}>, 'implementation': <{'dynamicRegistration': <false>}>, 'codeAction': <{'dynamicRegistration': <false>}>, 'codeLens': <{'dynamicRegistration': <false>}>, 'documentLink': <{'dynamicRegistration': <false>}>, 'colorProvider': <{'dynamicRegistration': <false>}>, 'rename': <{'dynamicRegistration': <false>, 'prepareSupport': <false>}>, 'publishDiagnostics': <{'relatedInformation': <false>}>, 'foldingRange': <{'dynamicRegistration': <false>, 'rangeLimit': <int64 0>, 'lineFoldingOnly': <false>}>}>}>, 'workspaceFolders': <@av []>}>}
[Nuevo Thread 0x7ffff272f640 (LWP 37566)]
jsonrpc-input-stream-Message: 07:56:43.010: <<< {"method":"initialize","jsonrpc":"2.0","id":1,"params":{"processId":1,"rootUri":"file:///home/esodan/Projects/gvls/tests","initializationOptions":{"autoConfigure":false,"defaultNamespaces":true,"defaultVapiDirs":false,"scanWorkspace":true,"addUsingNamespaces":false,"mesonBuildSystem":true,"files":[],"packages":[],"options":[],"valaArgs":[],"initialized":true,"targets":[]},"capabilities":{"workspace":{"applyEdit":false,"workspaceEdit":{"documentChanges":false,"resourceOperations":["create","rename","delete"]},"didChangeConfiguration":{"dynamicRegistration":false},"didChangeWhatchedFile":{"dynamicRegistration":false},"symbol":{"dynamicRegistration":false,"symbolKind":{"valueSet":[0,3,5,6,7,8,10,13,14,15,16,17,22,23]}},"executeCommand":{"dynamicRegistration":false},"workspaceFolders":false,"configuration":true},"textDocument":{"synchronization":{"dynamicRegistration":false,"willSave":false,"willSaveWaitUntil":false,"didSave":true},"completion":{"dynamicRegistration":false,"completionItem":{"snippetSupport":false,"commitCharactersSupport":true,"documentationFormat":["plaintext","markdown"],"deprecatedSupport":false,"preselectSupport":false},"completionItemKind":{"valueSet":[1,2,5,6,7,8,10,13,14,22]},"contextSupport":false},"hover":{"dynamicRegistration":false,"contentFormat":["markdown"]},"signatureHelp":{"dynamicRegistration":false},"references":{"dynamicRegistration":false},"documentHighlight":{"dynamicRegistration":false},"documentSymbol":{"dynamicRegistration":false,"symbolKind":{"valueSet":[3,5,6,8,10,11,13,15,23,22]},"hierarchicalDocumentSymbolSupport":true},"formatting":{"dynamicRegistration":false},"rangeFormatting":{"dynamicRegistration":false},"onTypeFormatting":{"dynamicRegistration":false},"definition":{"dynamicRegistration":false},"typeDefinition":{"dynamicRegistration":false},"implementation":{"dynamicRegistration":false},"codeAction":{"dynamicRegistration":false},"codeLens":{"dynamicRegistration":false},"documentLink":{"dynamicRegistration":false},"colorProvider":{"dynamicRegistration":false},"rename":{"dynamicRegistration":false,"prepareSupport":false},"publishDiagnostics":{"relatedInformation":false},"foldingRange":{"dynamicRegistration":false,"rangeLimit":0,"lineFoldingOnly":false}}},"workspaceFolders":[]}}
jsonrpc-output-stream-Message: 07:56:43.017: >>> {'result': <{'capabilities': <{'textDocumentSync': <int16 2>, 'definitionProvider': <true>, 'documentSymbolProvider': <true>, 'completionProvider': <{'triggerCharacters': <['.', '>']>}>, 'signatureHelpProvider': <{'triggerCharacters': <['(', '[', ',']>}>, 'hoverProvider': <true>, 'referencesProvider': <true>, 'documentHighlightProvider': <true>, 'implementationProvider': <true>, 'workspaceSymbolProvider': <true>, 'renameProvider': <{'prepareProvider': <true>}>, 'codeLensProvider': <{'resolveProvider': <false>}>}>, 'serverInfo': <{'name': <'Vala Language Server'>, 'version': <'0.48.4'>}>}>, 'jsonrpc': <'2.0'>, 'id': <int64 1>}
# jsonrpc-input-stream-MESSAGE: <<< {"result":{"capabilities":{"textDocumentSync":2,"definitionProvider":true,"documentSymbolProvider":true,"completionProvider":{"triggerCharacters":[".",">"]},"signatureHelpProvider":{"triggerCharacters":["(","[",","]},"hoverProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"implementationProvider":true,"workspaceSymbolProvider":true,"renameProvider":{"prepareProvider":true},"codeLensProvider":{"resolveProvider":false}},"serverInfo":{"name":"Vala Language Server","version":"0.48.4"}},"jsonrpc":"2.0","id":1}
jsonrpc-input-stream-Message: 07:56:43.017: <<< {"result":{"capabilities":{"textDocumentSync":2,"definitionProvider":true,"documentSymbolProvider":true,"completionProvider":{"triggerCharacters":[".",">"]},"signatureHelpProvider":{"triggerCharacters":["(","[",","]},"hoverProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"implementationProvider":true,"workspaceSymbolProvider":true,"renameProvider":{"prepareProvider":true},"codeLensProvider":{"resolveProvider":false}},"serverInfo":{"name":"Vala Language Server","version":"0.48.4"}},"jsonrpc":"2.0","id":1}
# MESSAGE: test-vls-initialization.vala:42: End initialization...
** Message: 07:56:43.018: test-vls-initialization.vala:42: End initialization...
# MESSAGE: test-vls-initialization.vala:43: Send shutdown request
** Message: 07:56:43.018: test-vls-initialization.vala:43: Send shutdown request
# jsonrpc-output-stream-MESSAGE: >>> {'method': <'shutdown'>, 'jsonrpc': <'2.0'>, 'id': <int64 2>, 'params': <'shutdown'>}
jsonrpc-output-stream-Message: 07:56:43.018: >>> {'method': <'shutdown'>, 'jsonrpc': <'2.0'>, 'id': <int64 2>, 'params': <'shutdown'>}
# jsonrpc-output-stream-MESSAGE: >>> {'method': <'initialized'>, 'jsonrpc': <'2.0'>, 'params': <@a{sv} {}>}
jsonrpc-output-stream-Message: 07:56:43.018: >>> {'method': <'initialized'>, 'jsonrpc': <'2.0'>, 'params': <@a{sv} {}>}

(vala-language-server:37562): vls-WARNING **: 07:56:43.506: mesonproject.vala:287: configuration failed with exit code 256
----stdout:
The Meson build system
Version: 0.56.2
Source dir: /home/esodan/Projects/gvls/tests
Build dir: /tmp/vls-meson-4217662860-H23PF1
Build type: native build

ERROR: First statement must be a call to project

A full log can be found at /tmp/vls-meson-4217662860-H23PF1/meson-logs/meson-log.txt

----stderr:


(vala-language-server:37562): vls-WARNING **: 07:56:43.527: server.vala:205: Failed to initialize Meson project - meson configuration failed with exit code 256
jsonrpc-output-stream-Message: 07:56:43.527: >>> {'method': <'window/showMessage'>, 'jsonrpc': <'2.0'>, 'params': <{'type': <int16 1>, 'message': <'Failed to initialize Meson project - meson configuration failed with exit code 256'>}>}
# jsonrpc-input-stream-MESSAGE: <<< {"method":"window/showMessage","jsonrpc":"2.0","params":{"type":1,"message":"Failed to initialize Meson project - meson configuration failed with exit code 256"}}
jsonrpc-input-stream-Message: 07:56:43.528: <<< {"method":"window/showMessage","jsonrpc":"2.0","params":{"type":1,"message":"Failed to initialize Meson project - meson configuration failed with exit code 256"}}

(vala-language-server:37562): vala-CRITICAL **: 07:56:43.754: vala_symbol_get_name: assertion 'self != NULL' failed

(vala-language-server:37562): vala-CRITICAL **: 07:56:43.755: vala_symbol_get_name: assertion 'self != NULL' failed

(vala-language-server:37562): vala-CRITICAL **: 07:56:43.756: vala_symbol_get_name: assertion 'self != NULL' failed

(vala-language-server:37562): vala-CRITICAL **: 07:56:43.756: vala_symbol_get_name: assertion 'self != NULL' failed

(vala-language-server:37562): vala-CRITICAL **: 07:56:43.760: vala_symbol_get_name: assertion 'self != NULL' failed

(vala-language-server:37562): vala-CRITICAL **: 07:56:43.763: vala_symbol_get_name: assertion 'self != NULL' failed

(vala-language-server:37562): vala-CRITICAL **: 07:56:43.766: vala_symbol_get_name: assertion 'self != NULL' failed

(vala-language-server:37562): vala-CRITICAL **: 07:56:43.769: vala_symbol_get_name: assertion 'self != NULL' failed

(vala-language-server:37562): vala-CRITICAL **: 07:56:43.770: vala_symbol_get_name: assertion 'self != NULL' failed

(vala-language-server:37562): vala-CRITICAL **: 07:56:43.780: vala_object_type_construct: assertion 'type_symbol != NULL' failed

(vala-language-server:37562): vala-CRITICAL **: 07:56:43.780: vala_interface_add_prerequisite: assertion 'type != NULL' failed
jsonrpc-input-stream-Message: 07:56:43.827: <<< {"method":"shutdown","jsonrpc":"2.0","id":2,"params":"shutdown"}
jsonrpc-output-stream-Message: 07:56:43.836: >>> {'result': <@mv nothing>, 'jsonrpc': <'2.0'>, 'id': <int64 2>}
# jsonrpc-input-stream-MESSAGE: <<< {"result":null,"jsonrpc":"2.0","id":2}
jsonrpc-input-stream-Message: 07:56:43.838: <<< {"result":null,"jsonrpc":"2.0","id":2}
# MESSAGE: test-vls-initialization.vala:47: Shutdown response: nothing
** Message: 07:56:43.838: test-vls-initialization.vala:47: Shutdown response: nothing
**
ERROR:../tests/vls/test-vls-initialization.vala:48:__lambda6_: assertion failed: ("ok" in msg)
Bail out! ERROR:../tests/vls/test-vls-initialization.vala:48:__lambda6_: assertion failed: ("ok" in msg)

Thread 1 "vls-initializat" received signal SIGABRT, Aborted.
__pthread_kill_implementation (no_tid=0, signo=6, threadid=140737293155264) at pthread_kill.c:44
44	pthread_kill.c: No existe el archivo o el directorio.

[Prince781]

@esodan VLS accepts the shutdown request, but sends null, as the specification requires.

[lw64]

I think this issue should be moved to gnome builder.

[Prince781]

@nahuelwexd Is this bug still happening?

[JCWasmx86]

This bug is still happening. I can confirm it. In the initialize request, the editor pid is called. Maybe VLS could check, all n minutes, if it still exists. If not exit automatically.