vala-language-server icon indicating copy to clipboard operation
vala-language-server copied to clipboard

Published 20 hours ago • verified publisher icon vala-lang

Auto-completion in string literals works

Open gavr123456789 opened this issue 5 years ago • 6 comments

Describe the bug A clear and concise description of what the bug is.

Software OS and version (e.g. Ubuntu 20.04): arch btw VSCode Vala Language Server (e.g. git commit, or PPA/AUR version): workflow-improvements branch Vala version (valac --version): 0.48.4

To Reproduce изображение

gavr123456789 avatar Apr 28 '20 06:04 gavr123456789

изображение wait, actually it can be good xdd.

gavr123456789 avatar Apr 28 '20 07:04 gavr123456789

Yeah, I can't decide if this should be a bug or not. It has its pros and cons. What do you think @benwaffle ?

Prince781 avatar May 02 '20 23:05 Prince781

It's a bug. Strings aren't expected to have correct symbols. If you need it, vscode handles autocompletion of words found in your file.

benwaffle avatar May 02 '20 23:05 benwaffle

Makes sense. It seems this would be expensive to avoid from the SymbolExtractor, since this would require searching (in the worst case) the entire document for quotation marks.

Prince781 avatar May 03 '20 00:05 Prince781

But I think it still should work in @ strings
image

gavr123456789 avatar May 12 '20 02:05 gavr123456789

One way to solve this is to create regions of a text document that aren't to have completions in them. These regions would be updated every time the document is compiled.

Prince781 avatar Jun 28 '20 21:06 Prince781