Vladislav Vaintroub

Results 40 comments of Vladislav Vaintroub

> @vaintroub Can you please evaluate if this PR should be merged or not? This eliminates pthread_kill is favor of more reliable API, thus I think it is good, and...

I think "dedicated thread" that is doing nothing, just waiting most of the time is a wrong idea. MySQL has multiplied threads for anything possible, "a thread that is waiting...

> We’re partly back to the drawing board. I think that the issue that the current revision may solve is that `mariadb-backup --backup` will stop copying the log upon reaching...

I also think mariadb_sleep_for_space() looks buggy. unlike in other cases (e.g SLEEP), it does not set mysys_var->current_mutex and mysys_var->current_cond, to mutex and condition it is waiting on, thus it can't...

I do not know why monty's fix works, given my previous comment. mysys_var->mutex and cond are not set. those are things that are getting used in KILL, or shutdown, at...

Checked again , monty's fix would work, because thd->ENTER_COND would set mysys_var->cond and mutex, but the request to add test where it is fix is available still stands. There are...

@portsip , thanks. #740 is still open, but now there is a repro for @daanx at least

hi @kareem-wolfssl , sorry my mistake. We use the latest 5.7.6, and this error stems directly from it. I have corrected the version now Yes, about the issue - my...

I'm reporting what I have seen, and what other people have seen (MariaDB users see the problem, while we have not, by using a later version of the compiler). I...

This static assert causes warnings with clang-cl compiler (Clang acting as-if it would be MSVC), which is probably not tested by suite. `In file included from E:\10.11\extra\wolfssl\wolfssl\wolfcrypt\src\error.c:29: E:\10.11\extra\wolfssl\wolfssl\wolfssl/wolfcrypt/error-crypt.h(321,1): warning: use...