commentjson Add support for NaN values

Add support for NaN values

Open mattpearson opened this issue 4 years ago • 4 comments

Oct 25 '20 18:10 mattpearson

What do you need NaN support for? What's the use-case?

Oct 27 '20 05:10 vaidik

What do you need NaN support for? What's the use-case?

If a json contains mathematical metadata, a value could be NaN (example: standard deviation of a list, with only 1 element, has a NaN std dev).

Separately, it brings compatibility with Python's other json library https://docs.python.org/3/library/json.html since it supports NaN values

Oct 27 '20 13:10 mattpearson

Any thoughts on the above?

Nov 06 '20 17:11 mattpearson

The changes look good. Can you please add some test cases for this change? I will merge afterwards.

Jan 23 '21 10:01 vaidik