commentjson icon indicating copy to clipboard operation
commentjson copied to clipboard

Allow ValueError to pass-through without exception conversion.

Open EliRibble opened this issue 5 years ago • 2 comments

This maintains compatibility with the Python json library which raises ValueError when it cannot parse a file.

EliRibble avatar Jun 19 '20 18:06 EliRibble

This is to address https://github.com/vaidik/commentjson/issues/43

EliRibble avatar Jun 19 '20 18:06 EliRibble

Thanks for the change. I see your point. Which version of Python are you using? I tried testing against Python 3.8 and I am getting json.decoder.JSONDecodeError instead.

Also, some tests are failing. Can you check these once please?

vaidik avatar Aug 23 '20 06:08 vaidik