Vaibhav Garg

Results 21 comments of Vaibhav Garg

> @vaibhavgarg237 tests are green here 🚀 Might be good to add a test for your change. I can help with that. I think tests are passing because it's only...

I was facing some issues related to running original tests locally. I have dm'ed you on slack regarding the same, kindly lemme know whenever you are available. Thanks

**I feel it shows 0 because initialState of currencyRate is set to be 0** https://github.com/getAlby/lightning-browser-extension/blob/49705ab42ed5f9efaeb4c1d21c7832610f0d1e2e/src/app/context/SettingsContext.tsx#L30 Here it is multiplying the currency rate with the amount, which might result in this...

I feel we can change [this](https://github.com/getAlby/lightning-browser-extension/blob/5156710bce3f21ce543a0f2fda89f0db2e724318/src/app/components/AccountMenu/index.tsx#L95-L97) with below mentioned [changes in the image ](https://gist.github.com/vaibhavgarg237/4f5bdfe160d9cea20c9b727f9d436d9b#file-index-tsx) Current Code: https://github.com/getAlby/lightning-browser-extension/blob/5156710bce3f21ce543a0f2fda89f0db2e724318/src/app/components/AccountMenu/index.tsx#L95-L97 Proposed Changes: ![image](https://user-images.githubusercontent.com/67408018/195389572-a808e1f8-21da-45e2-acb3-68f9bc7f6923.png)

> Hm, currency depends on the settings. So checking for i.e. `$` will not cover all cases, right? Oh I forgot that one. Will make it dynamic.

@escapedcat I have opened a PR for this issue with the proposed changes. Can you assign this issue to me?

> Instead of adding multiple disabled props to all kinds of components could we wrap the "formy" parts in a `form` like we do here?: https://github.com/getAlby/lightning-browser-extension/blob/master/src/app/screens/Send/index.tsx > > This could...

I think we can use Transifex for this

It's working properly If you select the text and then tap H1/H2 or any other then it's working... Can you please clearly mention steps for reproduction...

I think it's not a bug, it's a feature according to the maintainers 😂😂! Check https://github.com/facebook/draft-js in readme section. Checkout this [link](https://camo.githubusercontent.com/50551c59fb8c39c6c28f96a742753998c859aacb75f6b1242a69bf12cf900bc4/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f5848556a6178454c7063313153695253714e2f67697068792e676966) Here in this gif it should be as...