vagrant-libvirt icon indicating copy to clipboard operation
vagrant-libvirt copied to clipboard

Creating additional disks belongs in a seperate action

Open sciurus opened this issue 11 years ago • 3 comments

#178 added the ability to create additional disks. The code that was added to create_domain should be in new action, similar to create_domain_volume or create_network_interfaces. create_domain should be limited to creating the VM itself.

We should also look at moving methods added to config into another module.

sciurus avatar Oct 17 '14 02:10 sciurus

I caused this problem, so feel free to harass me to review patch and to buy the patch writer a $beverage.

purpleidea avatar Oct 20 '14 01:10 purpleidea

This is still valid. Flagging as enhancement.

infernix avatar Apr 25 '16 12:04 infernix

I too would contribute a beverage of the patcher's choosing.

It would be nice if when this is broken out, it supported when the user is bringing their own volume along and wants it uploaded to the storage provider.

cornfeedhobo avatar Sep 30 '23 13:09 cornfeedhobo