landrush icon indicating copy to clipboard operation
landrush copied to clipboard

Published 20 hours ago • verified publisher icon vagrant-landrush

Rename VMware Fusion support to VMware Desktop

Open nickcharlton opened this issue 4 years ago • 5 comments

On 2016-03-26, HashiCorp released the VMware Desktop Plugin, which replaced the existing VMware Fusion implementation. With the rename, the hooks that Landrush needs to start services can no longer be called. Renaming those makes those work again.

Fixes #334.

nickcharlton avatar Apr 23 '20 17:04 nickcharlton

I can't test this. But the tests passed, so I believe. :)

davividal avatar Apr 28 '20 22:04 davividal

I would've liked to have tested my changes too, but I couldn't work out how to do it. Running it locally, I found I wasn't able to run the tests for Landrush whilst having the (private) VMware provider plugin installed.

I don't suppose you have any suggestions?

nickcharlton avatar Apr 29 '20 08:04 nickcharlton

I never used VMware + Vagrant, so no.

davividal avatar Apr 29 '20 12:04 davividal

@hferentschik this one looks fine for me. What do you think?

davividal avatar May 22 '20 20:05 davividal

I'm conscious that this has been sat a little while without any activity. Is there anything I can help with to move this along?

nickcharlton avatar Oct 30 '20 12:10 nickcharlton