dxf-viewer icon indicating copy to clipboard operation
dxf-viewer copied to clipboard

Various MText improvements and small fixes

Open tth05 opened this issue 1 year ago • 3 comments

Almost forgot about this, I hope the commits are somewhat self-explanatory. Let me know if anything should be changed, although I never want to work with JS again. Would be great to see the TS port and new parser completed.

I used https://github.com/mozman/ezdxf/blob/master/docs/source/dxfinternals/entities/mtext.rst and https://github.com/skymakerolof/dxf/blob/develop/src/handlers/entity/mtext.js as references to figure stuff out and of course just playing around in AutoCAD.

I've attached a file which can be used to compare the before and after, mostly regarding MText columns. AutoCAD reference: image columns-all.dxf.txt

tth05 avatar Mar 26 '24 18:03 tth05

@vagran Have you looked at this yet?

tth05 avatar Jun 20 '24 14:06 tth05

@vagran Have you looked at this yet?

I took a look, and found it is quite a lot of changes from various areas. So it is still postponed for full review and most probably some refactoring, understanding and testing each change. PR has higher chance to be merged quickly if it fixes some single problem.

vagran avatar Jun 20 '24 14:06 vagran

Ok, no problem. Just didn't want to let this go to waste

tth05 avatar Jun 20 '24 19:06 tth05