vaex icon indicating copy to clipboard operation
vaex copied to clipboard

Add a `__dataframe__` method to `_VaexDataFrame`

Open rgommers opened this issue 1 year ago • 3 comments

This will align the implementation with those in other libraries, xref https://github.com/data-apis/dataframe-api/issues/80.

Cc @maartenbreddels, @honno

rgommers avatar Sep 13 '22 12:09 rgommers

(apologies for iterating in CI, I was a bit too lazy to set up a dev environment for these few lines of code)

rgommers avatar Sep 13 '22 13:09 rgommers

This seems happy now, the 4 CI failures I inspected are all HTTPClientError: HTTP 502: Bad Gateway.

rgommers avatar Sep 13 '22 14:09 rgommers

FWIW dataframe_protocol_tests.py and the relevant dunder-df tests in dataframe-interchange-tests pass for this PR locally.

(If the bad gateway stuff gets resolved, note there's other issues with interchange stuff on win/mac CI https://github.com/vaexio/vaex/pull/2150#issuecomment-1237847383)

honno avatar Sep 13 '22 14:09 honno

@maartenbreddels I somehow keep getting notifications for new failures on reruns of CI jobs. No worries if you are doing that on purpose - if not, something is probably off in the GitHub Actions config in this repo.

The only failures are still (7x):

FAILED tests/viz_test.py::test_heatmap_with_what[webserver_fastapi-ds_filtered-tornado_client]

rgommers avatar Sep 22 '22 15:09 rgommers

Yeah, that was me :) I had to rebase, hopefully it is green now.

maartenbreddels avatar Sep 23 '22 10:09 maartenbreddels

green enough, thanks Ralf!

maartenbreddels avatar Sep 23 '22 11:09 maartenbreddels

great, thanks!

rgommers avatar Sep 23 '22 12:09 rgommers