Michal Rostecki

Moved to "Todo" - I'm going to get back to it once the new Linux incidents are done.

Resuming work on this now. So far I still didn't get it fully working. My port of the relocation part (libbpf code https://github.com/torvalds/linux/commit/5bd022ec01f06#diff-333e3796217dda054b006e3cfe59f542121cf8a07f67f21c6ab7851ecf0c02e1R3162-R3197) still doesn't result in loadable program, I...

@nsengupta Sorry for even later reaction from my side! Could you rebase your PR? You will likely get some markdownlint errors to fix. For the next time, could you also...

The initial pull request introducing the syscall along with a subsequent fix have both been merged successfully: * #27961 * #28955 Currently, there remains an outstanding pull request: * #31436...

@mvines Yes, I see that my last PR made it to 1.16 branch. Thank you!

I'm actually quite surprised that rust compiler-builtins don't optimize this implementation somehow (by loading bigger chunks and reducing iterations). I think in eBPF we could load with `u64` chunks. But...

I think if you are able to write a small program which triggers the error on your kernel, it's almost certainly going to be a reliable reproduces. Just avoid `clone()`...

> I have added an integration test, and simplified the implementation of `memmove`. The integration test will fail when the `memmove` code is commented out, it passes when `memmove` is...

@wdullaer Lint errors look legit. The integration test errors should be gone after a rebase.

To be precise - a great place to add tests would be https://github.com/aya-rs/aya/blob/main/test/integration-ebpf/src/map_test.rs A simple `set` call on any kind of map with some dummy values would be enough :slightly_smiling_face: