ink icon indicating copy to clipboard operation
ink copied to clipboard

Update required Node.js version to at least 12

Open loreanvictor opened this issue 3 years ago • 1 comments

Currently on the package it is mentioned that it is compatible with node>=10. However, just had an issue with a coworker running node v10.12.0 which couldn't run an internal CLI tool based on ink, and resolved it by simply upgrading node. This was the issue that got resolved:

.../node_modules/yoga-layout-prebuilt/yoga-layout/build/Release/nbind.js:53
        throw ex;
        ^

Error: Cannot find module 'fs/promises'
    at Function.Module._resolveFilename

Perhaps the engine requirement should be bumped to node>=10.24?

loreanvictor avatar Feb 12 '22 10:02 loreanvictor

Good catch! Any version requirements changes should probably be in major release, so I'll keep this open for v4.

vadimdemedes avatar Feb 17 '22 17:02 vadimdemedes

Fixed in #543.

vadimdemedes avatar Mar 17 '23 23:03 vadimdemedes