ink-select-input icon indicating copy to clipboard operation
ink-select-input copied to clipboard
verified publisher icon vadimdemedes

Add onHighlight prop

Open chrisforrette opened this issue 7 years ago • 4 comments

Hey there. This and the rest of ink has been really rad, thanks for all your hard work!

It would be pretty nice (and helpful for a current project) to have the ability to pass an onHighlight prop (or something like that) that would be invoked when an item is highlighted, e.g. when the up or down arrows are pressed (but not when enter is pressed), and I'd be happy to get a PR together for it if it's something you're open to. Let me know what you think, thanks!

chrisforrette avatar Nov 14 '18 17:11 chrisforrette

I'd also like to have this. I wanna print how many items there are left to scroll down to (using limit)

SimenB avatar Mar 09 '19 07:03 SimenB

I would suggest this being called onChange.

zimme avatar Mar 14 '19 21:03 zimme

There's a PR for this here #16 and as I was out voted on the name, it's called onHighlight =)

zimme avatar Mar 23 '19 09:03 zimme

Fixed via #16, will keep this issue open until new release is out.

vadimdemedes avatar Mar 28 '19 02:03 vadimdemedes