codelldb icon indicating copy to clipboard operation
codelldb copied to clipboard

rust formatters: fix a bug with vecdeque.

Open 8thMage opened this issue 1 year ago • 5 comments

in this issue: https://github.com/rust-lang/rust/issues/118331 there's shown a bug where vecdeque doesn't show the values inside a vecdeque. As commented by me in the issue, this change https://github.com/rust-lang/rust/commit/502df1b7d4f3ba61d55cf2b3a47785a7a4df940b broke the current formatter, as it transformed capacity from a POD to a struct. This pr reads the capacity from that struct.

8thMage avatar Apr 29 '24 21:04 8thMage

@vadimcn hey, is there any updates to merging this? Not being able to debug vecdeque hurts.

8thMage avatar May 11 '24 09:05 8thMage

@puremourning do you have write permissions? If not, can you contact someone who have them?

8thMage avatar May 11 '24 17:05 8thMage

Can anyone merge this pull request? It's really important for my workload

8thMage avatar May 27 '24 16:05 8thMage

stuck with that as well. I am seeing this problem with debugging my program that uses lopdf library which, due to the nature of PDFs, uses a lot of nested data structures. Debugging is an absolute pain right now.

markusdd avatar Jun 01 '24 11:06 markusdd

@puremourning do you have write permissions? If not, can you contact someone who have them?

no I don't, and no I can't.

puremourning avatar Jun 01 '24 13:06 puremourning

@vadimcn any update?

8thMage avatar Jul 05 '24 13:07 8thMage

The last merge was from almost a year ago. Probably time to consider this abandoned and create a fork.

zmitchell avatar Aug 25 '24 18:08 zmitchell

I wouldn't say "completely abandoned." However, I haven't had much time lately to track upstream changes in LLVM and Rust projects. Since mainline LLDB has recently gained the ability to parse DWARF info for Rust enums, I will likely revert codelldb's fork of LLDB to something much closer to mainline in the next release, relying instead on the formatters shipped with rustc. As such, merging this change into codelldb doesn't make much sense.

vadimcn avatar Aug 26 '24 16:08 vadimcn

For those being affected, try this. It worked for my case. Now I can get back to coding.
rustup install nightly-2024-08-01 cargo +nightly-2024-08-01 build rustup override set nightly-2024-08-01 .

(from https://github.com/vadimcn/codelldb/issues/1142#issuecomment-2388770235)

alebairos avatar Oct 06 '24 00:10 alebairos