electron-google-analytics icon indicating copy to clipboard operation
electron-google-analytics copied to clipboard

Suggestions

Open lekoaf opened this issue 5 years ago • 0 comments

While working on the PR to convert this repo to typescript, I found a few things that perhaps could be improved.

For instance:

  • Add lib to .gitignore
  • Give the user the ability to specify their own globalBaseURL and globalCollectURL
  • Give the user the ability to send in options to electron-fetch (useful for proxy stuff etc)
  • globalBatchURL is unused. Should it be used or removed?
  • A lot of the parameter names are needlessly abbreviated. It just makes it harder for the user to use them.
  • This lib would be easier to use if you could send in all parameters as objects. It would also give nicer type interfaces.

lekoaf avatar Oct 01 '20 20:10 lekoaf