electron-google-analytics
electron-google-analytics copied to clipboard
Suggestions
While working on the PR to convert this repo to typescript, I found a few things that perhaps could be improved.
For instance:
- Add
libto .gitignore - Give the user the ability to specify their own
globalBaseURLandglobalCollectURL - Give the user the ability to send in options to electron-fetch (useful for proxy stuff etc)
-
globalBatchURLis unused. Should it be used or removed? - A lot of the parameter names are needlessly abbreviated. It just makes it harder for the user to use them.
- This lib would be easier to use if you could send in all parameters as objects. It would also give nicer type interfaces.