rfc icon indicating copy to clipboard operation
rfc copied to clipboard

6/WAKU1: Document the rest of Whisper packets

Open adambabik opened this issue 5 years ago • 6 comments

Problem

Not all packets are currently covered by the spec.

  • [ ] 11 Batch Ack
  • [ ] 12 Message Response
  • [ ] 123 P2P Sync Request
  • [ ] 124 P2P Sync Response

Acceptance criteria

Align with the PR https://github.com/status-im/specs/pull/72.

adambabik avatar Dec 08 '19 15:12 adambabik

What's the state of this @adambabik and @decanus?

oskarth avatar Dec 16 '19 02:12 oskarth

Need to port https://github.com/status-im/specs/pull/72.

adambabik avatar Dec 16 '19 07:12 adambabik

@adambabik it looks like the ones which aren't ported are packet codes that are marked as TODO in the spec.

decanus avatar Dec 17 '19 23:12 decanus

@adambabik @decanus Is this issue still relevant? Given discussion yesterday, can we update this issue?

oskarth avatar Jan 14 '20 11:01 oskarth

@oskarth it looks like most of them still need to be ported.

decanus avatar Jan 14 '20 14:01 decanus

6/WAKU1 spec not priority, PRs welcome though

oskarth avatar Mar 31 '21 06:03 oskarth

Closing, 6/WAKU1 is in stable status.

jimstir avatar Jun 13 '24 19:06 jimstir