rfc icon indicating copy to clipboard operation
rfc copied to clipboard

2/MVDS: Change `message_id`s to a multihash

Open decanus opened this issue 6 years ago • 5 comments

Problem

We currently do not use multihash meaning we are bound to a single hashing algorithm.

Solution

The message_ids are described to be multihashes.

decanus avatar Sep 24 '19 05:09 decanus

To deal with fixed length indexing problem in e.g. Go, perhaps padding to a fixed length and using that would work? I'm sure a lot of codebases using multihashes also use indexing.

oskarth avatar Sep 24 '19 05:09 oskarth

@oskarth should work, because we will know what the length of our hashes has to be.

decanus avatar Sep 24 '19 14:09 decanus

@decanus A good follow up issue on this would be to ensure there's a good story for compatibility and upgrades. That issue would then be a blocker for this one.

Removing from milestone, if you disagree we can talk about it

oskarth avatar Oct 22 '19 05:10 oskarth

@oskarth, I agree. We should discuss compatibility on top of MVDS more and make this a part of it.

decanus avatar Oct 22 '19 07:10 decanus

Ping re compatibility discussion issue

oskarth avatar Dec 16 '19 02:12 oskarth

Closing, 2/MVDS is in stable status.

jimstir avatar Jun 13 '24 19:06 jimstir