nim-libp2p icon indicating copy to clipboard operation
nim-libp2p copied to clipboard

Remove shallow copies

Open Menduist opened this issue 1 year ago • 0 comments

Beside not being compatible with orc, they can introduce weird / unsafe behaviors.

They seemed to be used only in places with a few bytes (worst case being private keys around 256 bytes), so I doubt we'll see any performance regression, but I have a branch with when defined(shallowCopy) everywhere ready if that's the case

Menduist avatar Sep 30 '22 08:09 Menduist