python-holidays icon indicating copy to clipboard operation
python-holidays copied to clipboard

Published 20 hours ago • verified publisher icon vacanza

Bug fix of substitute holidays in Japan

Open shohirose opened this issue 2 years ago • 1 comments

Substitute holidays for Reiwa Emperor's Birthday (Feb 23) after 2020 are added. In addition, a test for substitute holidays in Japan between 2024 and 2040 is added.

shohirose avatar Sep 24 '22 12:09 shohirose

Coverage Status

Coverage decreased (-0.003%) to 99.575% when pulling ee8029935d8b6a5599a837f900f722a791fe9973 on shohirose:beta into fef5336bdceb61cdced8f5633b331d22deb4a927 on dr-prodigy:beta.

coveralls avatar Oct 05 '22 10:10 coveralls

Hi @shohirose @kasya thank you both! Would you please update this PR with tests coverage for the new substitute holidays? Thx KUTGW!

dr-prodigy avatar Oct 16 '22 10:10 dr-prodigy

Hi @dr-prodigy . Thank you for your comments. All of the substitute holidays in Japan between 1949 and 2050 are added to the test. In addition, other holidays are tested more thoroughly.

shohirose avatar Oct 16 '22 14:10 shohirose

That's great @shohirose ! Thank you very much, I've just merged your work in beta. Cheers

dr-prodigy avatar Oct 17 '22 20:10 dr-prodigy