python-holidays
python-holidays copied to clipboard
vacanza
Fix observed holiday for christmas and boxing day canada
For Canada, Christmas and Boxing day were now showing the non-observed day, unlike the other holidays for Canada.
Could you change the coveralls failure threshold to 0.1% or something instead of 0% please?
Pull Request Test Coverage Report for Build 3065597678
- 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.0002%) to 99.602%
| Totals | |
|---|---|
| Change from base Build 3061679434: | -0.0002% |
| Covered Lines: | 6545 |
| Relevant Lines: | 6558 |
💛 - Coveralls
Hi @bkthomps , thank you for your contribution. Regarding your last request (failure threshold) it is in fact meant to keep coverage level at the pre-existing state, so that's why we require a 0% loss to pass checks ( = all reviewed / added code should be covered). Could you please review your PR to integrate unit tests for all your changes? Please let me know if you are experiencing inconsistencies in the coverage calculation and check, thank you!
@dr-prodigy the test coverage is still on those lines, but since I removed 2 lines it's trivially less.
The coverage decrease is -4.0e-05% so -0.00004% less. Can we make the minimum some small delta at least to prevent this case? Like 0.01% or something? When I fixed a typo for Cuba it was -0.0% less and was failing the checks, so a small delta would fix this.
Hi @bkthomps, thank you for your notes and suggestions.. I've updated the coverage threshold and merged your PR in beta. KUTGW