python-holidays icon indicating copy to clipboard operation
python-holidays copied to clipboard

Published 20 hours ago • verified publisher icon vacanza

Adds municipal holidays for Porto and Lisboa.

Open thylux opened this issue 2 years ago • 1 comments

Ext list doesn't seem that common to me, so I only added to the city holidays the ones I think are more common pseudo-holidays

thylux avatar Sep 14 '22 23:09 thylux

Hi @thylux thank you for your contribution. In order to have it received, you should integrate it with unit tests to cover all your new holiday declarations. Pls refer to library documentation for further details. Thx, best regards

dr-prodigy avatar Oct 04 '22 09:10 dr-prodigy

I've added the list of holidays for the 18 portuguese districts ... https://github.com/dr-prodigy/python-holidays/pull/753 Regarding the Ext list, I agree with @thylux ... That list is not consensual, and I would vote to remove it.

pmpbaptista avatar Oct 21 '22 01:10 pmpbaptista

@Nalguedo thanks, I completely forgot about this PR. Given yours is more complete, I'll close this one.

thylux avatar Oct 21 '22 08:10 thylux