python-holidays
python-holidays copied to clipboard
vacanza
Holiday names sorting
While I was working on Bolivia holidays one of my tests caught an error with holiday names when two holidays fall on the same day. In this particular case it was one regional holiday (La Tablada in Tarija) and Viernes Santo holiday. In 2022 they both fell on Apr 15, so I had to make a separate test for this case. But to test it I needed to know the logic behind how names are combined.
I checked the code and noticed that there was no "rule" for holiday names order in such cases, and that makes testing much harder.
@dr-prodigy Would it be ok to submit a PR with a change to this fundamental logic?
Hi @kasya thank you for this interesting case! Indeed, we don't have a clear definition of behaviour in case of holidays overlapping.. being holidays a Dict-based class, we can't in fact add more than one holiday on the same date right away. Then, it would surely be valuable to add a standard logic to cover those cases: it would be useful especially regarding moving holidays (eg: Easter, Good Friday, etc.). My suggestion, whenever it happens, is, while keeping one single date element, to define a standard format to include all the holiday descriptions: they could be comma/semicolon separated, or new lines. This will probably imply some country holidays code refactoring too (I remember we have some custom logic regarding this in the project already), but that will come probably later.. Please, go on.. I'll be glad to participate to this development and include it in a PR. Thank you!
Is this still an issue, or has #713 closed/solved this? :)
#713 solved this issue (holiday names are now sorted alphabetically when 2 or more holidays fall on the same date).