python-holidays icon indicating copy to clipboard operation
python-holidays copied to clipboard

Add multi-level subdivision support

Open arkid15r opened this issue 1 year ago • 3 comments

Many entities have multi-level subdivision structure (see https://github.com/vacanza/python-holidays/issues/1710 request for adding Barcelona holidays, where province ES-B has autonomous community ES-CT as parent -- https://www.iso.org/obp/ui/#iso:code:3166:ES).

As long as the structure is defined by ISO3166-2 it'd be significant improvement to have multi-level subdivision support. We've added subdivision alias support recently so it won't be an issue to have Barcelona -> B mapping.

A couple of aspects to think through:

  • parent/child relation implementation
  • parent subdivision holidays population approach

arkid15r avatar Mar 02 '24 02:03 arkid15r

Hi! I'm Anupam, an aspiring GSoC 2025 contributor. I've thoroughly gone through the documentation and have been exploring the Vacanza/Holidays codebase for some time now.

After reviewing multiple issues and ideas, I found this one—"Add multi-level subdivision support"—to be the best fit for my skills and interests. It aligns perfectly with my goal to contribute meaningfully to this project.

I've already forked and cloned the repo, and I understand how the subdiv parameter is handled internally. I’d love to start working on this and submit an initial patch soon.

Could you please assign this issue to me so I can start working on its implementation? Thank you!

Anupam11421 avatar Apr 05 '25 10:04 Anupam11421

Hi @Anupam11421 I suggest focusing on one of the good first issues

arkid15r avatar Apr 05 '25 20:04 arkid15r

Hi @arkid15r, Thank you so much for the guidance! I completely understand. I’ll shift my focus to one of the good first issues to become more familiar with the codebase and contribution process.

I’ve recently made a successful PR for a minor feature, and I’m enjoying working with the project. I’ll now look into the suggested issues and continue contributing step by step.

Excited to keep learning and growing here 🚀 Thanks again for the support!

Anupam11421 avatar Apr 06 '25 07:04 Anupam11421