python-holidays icon indicating copy to clipboard operation
python-holidays copied to clipboard

Extend subdiv arg to accept multiple values

Open arkid15r opened this issue 2 years ago • 7 comments

Add ability to request holidays for more than one entity's subdivision. Keep it backward compatible.

arkid15r avatar Aug 24 '23 16:08 arkid15r

This sounds helpful. The categories and years parameters already accept multiple values. I was looking into this for my organisation that is spread across multiple Australian states. I think to work around the current lack of this feature I'll probably have to manually combine the holidays for each state into a set. Holidays given without any subdiv parameter are only holidays observed across the entire country.

Wedge009 avatar Nov 07 '24 22:11 Wedge009

I think I once started implementing this for v0 but I'm not sure if it'll make it there. Will definitely take another look for v1 support.

arkid15r avatar Nov 11 '24 21:11 arkid15r

I managed to work around it as described above, but definitely a 'nice-to-have' feature.

Wedge009 avatar Nov 12 '24 04:11 Wedge009

@arkid15r do we want to add this to #2345 ?

PPsyrius avatar Mar 26 '25 02:03 PPsyrius

It seems (based on the label) I didn't plan to add it into v0 initially. I believe it can be done in a backward-compatible way so why not? @KJhellico @PPsyrius wdyt?

arkid15r avatar Mar 26 '25 04:03 arkid15r

I'm in favor of implementing them beforehand, maybe alongside a way to get all subdivisions as well - perhaps subdiv=ALL?

PPsyrius avatar Mar 26 '25 04:03 PPsyrius

Why not? 👍

maybe alongside a way to get all subdivisions as well - perhaps subdiv=ALL?

It sounds interesting.

KJhellico avatar Mar 26 '25 11:03 KJhellico