web-components icon indicating copy to clipboard operation
web-components copied to clipboard

Upload component - remove selected file by triggering X button, close its parent ContextMenu (or any other balloon)

Open guygoldwasser opened this issue 11 months ago • 2 comments

Description

like described here: https://github.com/vaadin/web-components/issues/6986 same issue persist with the file upload component. After select a file, file/s can be removed. The click to remove, is also closing the parent balloon/ContextMenu

Expected outcome

No closing of ancestor popup

Minimal reproducible example

Button popupButton = Button("pop"); VerticalLayout layout = new VerticalLayout(); .... //create some buffer .... layout.add(new com.vaadin.flow.component.upload.Upload(buffer)); ContextMenu popup = new ContextMenu(popupButton); popup.add(layout); popup.setOpenOnClick(true);

Steps to reproduce

  1. create some float popup that close when click outside it
  2. push inside Upload component
  3. open popup and upload a file
  4. remove the file

Environment

Vaadin version(s): 24.5.3 OS: Windows 11

Browsers

Chrome

guygoldwasser avatar Mar 14 '24 11:03 guygoldwasser

Dear @guygoldwasser, would something like dialog with API for positioning suit this use-case or you prefer to use context-menu, and if so could you please describe the motivation behind it?

yuriy-fix avatar Mar 14 '24 14:03 yuriy-fix

We user slider panel that consist upload. click is closing the slider.

guygoldwasser avatar Mar 14 '24 21:03 guygoldwasser

Dear @guygoldwasser, could you please elaborate a bit more on the details about usage of slider panel and upload? Could you also please provide a screenshot?

yuriy-fix avatar Mar 21 '24 14:03 yuriy-fix

Closing as stale. Feel free to re-open if still valid.

yuriy-fix avatar May 16 '24 13:05 yuriy-fix

i am not sure what difference is make if it slider or some whatever popup that contains the upload component. same like we had with date when select on calendar close the below popup.

UX experts do the design, and decided that upload component will be in slider which is technically equivalent to popup. it same same like https://github.com/vaadin/web-components/issues/6986

guygoldwasser avatar May 28 '24 09:05 guygoldwasser