web-components icon indicating copy to clipboard operation
web-components copied to clipboard

[control-state-mixin] Rename focus-ring to focus-visible

Open abdonrd opened this issue 4 years ago • 1 comments

I know it would be a breaking change, but...

Would it make sense to rename focus-ring to focus-visible? To be closer to the specification: https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible

https://github.com/vaadin/component-mixins/blob/c83bb8903ef1a84e011035b3ba30a99dfbc98e7f/packages/focus-visible-mixin/focus-visible-mixin.ts#L76-L82

abdonrd avatar Jun 18 '20 11:06 abdonrd

This was considered when working on vaadin/component-mixins#11 and is planned to be done in future.

The only reason to keep it would be consistency, as most of components are still Polymer based (and it's unlikely that we manage to finish the conversion any time soon).

web-padawan avatar Jun 18 '20 11:06 web-padawan