platform icon indicating copy to clipboard operation
platform copied to clipboard

Vaadin Maven Plugin not thread-safe

Open knoobie opened this issue 1 year ago • 4 comments

Describe the bug

    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - *****************************************************************
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * Your build is requesting parallel execution, but this         *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * project contains the following plugin(s) that have goals not  *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * marked as thread-safe to support parallel execution.          *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * While this /may/ work fine, please look for plugin updates    *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * and/or request plugins be made thread-safe.                   *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * If reporting an issue, report it against the plugin in        *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * question, not against Apache Maven.                           *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - *****************************************************************
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - The following plugins are not marked as thread-safe in Project Name:
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon -   com.vaadin:vaadin-maven-plugin:24.4.10
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon -
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - Enable debug to see precisely which goals are not marked as thread-safe.
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - *****************************************************************

Expected-behavior

No such error.

Reproduction

Build any Vaadin Multi Module Project with Maven and enable parallel execution to speed up build.

System Info

Latest 24.4

knoobie avatar Aug 23 '24 07:08 knoobie

I have seen this message before when building platform o flow-components that are using parallel execution, but we have not experienced any problem, so we just ignore the message, has you had any issue in your projects?

manolo avatar Aug 23 '24 07:08 manolo

Not seen a problem in the final product; but maven is literally crying ;) and all WARNING logs are preserved in Jenkins.. so it's not a good DX / advertising for the plugin

knoobie avatar Aug 23 '24 07:08 knoobie

which goal do you expect to be thread-safe ? prepare-frontend or build-frontend ?

manolo avatar Aug 23 '24 14:08 manolo

I would expect build-frontend used in the production build to be thread-safe.. I would say even running a multi module project with different Vaadin modules should not be a problem because each has its own node modules, package json etc.

knoobie avatar Aug 23 '24 14:08 knoobie