platform icon indicating copy to clipboard operation
platform copied to clipboard

PiT 24.4: remove deprecated API usage in starters

Open manolo opened this issue 9 months ago • 1 comments

Describe the bug

There are a bunch of starters that are using deprecated API in 24.4

  • [ ] business-app-starter-flow Deprecated API:
src/test/java/com/vaadin/starter/business/it/AccountsIT.java:[28,47] attributeContains(java.lang.String,java.lang.String) in com.vaadin.testbench.ElementQuery has been deprecated
  • [ ] bookstore-example Deprecated API:
src/test/java/org/vaadin/example/crud/SampleCrudViewIT.java:[71,31] attribute(java.lang.String,java.lang.String) in com.vaadin.testbench.ElementQuery has been deprecated
  • [ ] bookstore-example:rtl-demo Deprecated API:
src/test/java/org/vaadin/example/crud/SampleCrudViewIT.java:[71,31] attribute(java.lang.String,java.lang.String) in com.vaadin.testbench.ElementQuery has been deprecated
  • [ ] bakery-app-starter-flow-spring Deprecated API:
src/test/java/com/vaadin/starter/bakery/testbench/elements/components/OrderCardElement.java:[11,56] attributeContains(java.lang.String,java.lang.String) in com.vaadin.testbench.ElementQuery has been deprecated
src/test/java/com/vaadin/starter/bakery/testbench/elements/components/OrderCardElement.java:[18,36] attributeContains(java.lang.String,java.lang.String) in com.vaadin.testbench.ElementQuery has been deprecated
src/test/java/com/vaadin/starter/bakery/testbench/elements/ui/OrderItemEditorElement.java:[27,59] attribute(java.lang.String,java.lang.String) in com.vaadin.testbench.ElementQuery has been deprecated

Expected-behavior

no usage of deprecated

Reproduction

.

System Info

V 24.4.0.beta2

manolo avatar May 09 '24 06:05 manolo

this deprecation has been introduced since Vaadin testbench 9.3.0.alpha1

at this moment, we cannot update the starters' v24 branch to use it, as they are still using Vaadin 24.3.x we will revisit those after v24.4.0 got released.

ZheSun88 avatar May 10 '24 07:05 ZheSun88

https://github.com/vaadin/business-app-starter-flow/pull/364 https://github.com/vaadin/bookstore-example/pull/337 https://github.com/vaadin/bookstore-example/pull/338 https://github.com/vaadin/bakery-app-starter-flow-spring/pull/1357

ZheSun88 avatar Jun 13 '24 06:06 ZheSun88

merged PRs, tested one with https://github.com/vaadin/platform/actions/runs/9495138942

ZheSun88 avatar Jun 13 '24 07:06 ZheSun88