platform icon indicating copy to clipboard operation
platform copied to clipboard

Vaadin uses old version of JSOUP which is binary incompatible with newer versions

Open benstpierre opened this issue 2 years ago • 2 comments

Describe the bug

It appears that as of 23.1.6 Vaadin uses JSOUP 1.14.3. In JSOUP 1.15.3 There was a breaking change where Whitelist was replaced with Safelist as the term "Whitelist" is considered racist. https://jsoup.org/news/release-1.15.1

We cannot use the new version of JSOUP because vaadin depends on the old version and uses the Whitelist class.

This should be a pretty small fix for Vaadin.

Expected-behavior

No response

Reproduction

Try to uses JSOUP 1.15.1 in a Vaadin 23 app and it will break.

System Info

Happens on all systems.

benstpierre avatar Aug 12 '22 16:08 benstpierre

Thanks for using Vaadin! We appreciate your help and we’ll take care of this as soon as possible.

vaadin-bot avatar Aug 12 '22 16:08 vaadin-bot

The new jsoup version can be used with 23.2 by default. In 23.1 you have to do some more work to get it to work without breaking stuff.

knoobie avatar Aug 12 '22 16:08 knoobie

we are working on a fix to make the new jsoup version working with V23.1 and older vaadin versions

ZheSun88 avatar Sep 01 '22 06:09 ZheSun88

Timely fixes for Vaadin 8 and Vaadin 14 would be quite important as well. Do I understand correctly, that you may not update the dependency directly, but will make sure that your code will be compatible with 1.15.X, so that we can package an updated version safely?

nittka avatar Sep 05 '22 12:09 nittka

Vaadin (flow) releases 14-23.2 with a fix including the transitive dependency are already on the way. An update for v8 (8.17) as extended maintenance release is prepared by Tatu as well.

knoobie avatar Sep 05 '22 12:09 knoobie

All affected Vaadin versions, 23.2.0, 23.1.9, 23.0.16, 22.0.22, 14.8.17, 10.0.21, 8.17.0 and 7.7.34 have been released with the Jsoup version updates.

ZheSun88 avatar Sep 08 '22 08:09 ZheSun88