hilla icon indicating copy to clipboard operation
hilla copied to clipboard

(WIP) resolve circular dependency

Open ZheSun88 opened this issue 3 years ago • 3 comments

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • [ ] Bugfix
  • [ ] Feature

Checklist

  • [ ] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • [ ] I have added a description following the guideline.
  • [ ] The issue is created in the corresponding repository and I have referenced it.
  • [ ] I have added tests to ensure my change is effective and works as intended.
  • [ ] New and existing tests are passing locally with my change.
  • [ ] I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • [ ] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

ZheSun88 avatar Sep 28 '22 07:09 ZheSun88

Codecov Report

Base: 96.67% // Head: 96.67% // No change to project coverage :thumbsup:

Coverage data is based on head (a24f1fc) compared to base (5082811). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   96.67%   96.67%           
=======================================
  Files          28       28           
  Lines        4659     4659           
  Branches      300      300           
=======================================
  Hits         4504     4504           
  Misses        152      152           
  Partials        3        3           
Flag Coverage Δ
unittests 96.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 28 '22 07:09 codecov[bot]

the error from the validation is

Stderr: 'vite v3.1.0 building for production...
Error:  transforming...
Error:  ✓ 103 modules transformed.
Error:  [vite]: Rollup failed to resolve import "@vaadin/field-base/src/field-mixin.js" from "node_modules/@vaadin/checkbox-group/src/vaadin-checkbox-group.js".

and there is a missing dependency in vaadin-checkbox-group, let us try this after the next web-component release.

ZheSun88 avatar Sep 28 '22 11:09 ZheSun88

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 28 '22 06:10 sonarqubecloud[bot]