hilla icon indicating copy to clipboard operation
hilla copied to clipboard

Servlet in Production mode shows error dialog

Open denis-anisimov opened this issue 5 years ago • 3 comments

See ClientSideExceptionHandlingIT::productionModeExceptions .

In CCDM branch there is no anymore compatibility mode. The test fails in NPM mode. The view is opened using URI mapping view-production (which is handled by the ProductionModeViewTestServlet working in production mode). In production mode the client side exception should not be shown (even though the client side is not built for production).

The test is disabled via @Ignore in CCDM branch. It should be enabled back once the ticket is fixed.

denis-anisimov avatar Jan 06 '20 12:01 denis-anisimov

One more test: DependencyIT::loadingUnavailableResourcesProduction. Ignored in CCDM branch.

denis-anisimov avatar Jan 06 '20 12:01 denis-anisimov

The problem is in DeploymentConfigurationFactory::readBuildInfo code which reads the token file (if it exists). The productionMode init parameter is correctly set to true based on the servlet configuration but then it's reset to false because its value read from the token file.

denis-anisimov avatar Jan 07 '20 05:01 denis-anisimov

More tests that rely on production mode config: ExportedJSFunctionIT::profilingInfoNotAvailableInProduction ExportedJSFunctionIT::productionModeTrueInProductionMode ExportedJSFunctionIT::versionInfoNotAvailableInProductionMode InfoIT::productionModeServlet RouteNotFoundProdModeIT

denis-anisimov avatar Jan 07 '20 05:01 denis-anisimov