hilla icon indicating copy to clipboard operation
hilla copied to clipboard

The `description` property of the `@PWA` annotation is ignored

Open vlukashov opened this issue 5 years ago • 0 comments

When using the @PWA annotation to make my Vaadin app installable to home screen, I want to see the application description specified in the description property of the @PWA annotation in the web application manifest at the run time, so that I can control the application metadata as in V12-V17. With V18 (Flow 5.0.offline-SNAPSHOT) it's not the case - the description property seems to be ignored.

Steps to reproduce

  1. create a Vaadin 17 app from start.vaadin.com
  2. override the version of Flow to 5.0.offline-SNAPSHOT
  3. set the description in the @PWA annotation:
    @SpringBootApplication
    @PWA(
        name = "v18-offline-test",
        shortName = "v18-offline-test",
        description = "Vaadin 18 offline app test",
    )
    public class Application extends SpringBootServletInitializer implements AppShellConfigurator {}
    
  4. start the app and check the http://localhost:8080/manifest.webmanifest file
  5. see that the description property is missing
  6. compare with V17 and see that there this property is present

Workaround

  1. create the Web manifest file manually and add the needed description property to it
  2. save the file to a static resources directory (e.g. src/main/webapp/manifest.webmanifest or src/main/resources/META-INF/resources/manifest.webmanifest)
  3. (if the URL of the manually-added manifest file differs from the default: /manifest.webmanifest) add a manifestPath = "url/of/the/manifest/file" property to the @PWA annotation

vlukashov avatar Oct 07 '20 21:10 vlukashov