hilla icon indicating copy to clipboard operation
hilla copied to clipboard

feat(full-stack signals): make operations thenable

Open cromoteca opened this issue 1 year ago • 3 comments

This pull request introduces a feature to make operations "thenable", which means it implements the ability for operations to return promise-like objects that can be chained. Those objects are in the result properties to avoid the return type themselves to be treated as promises by lint checkers.

Closes #2712

cromoteca avatar Oct 07 '24 15:10 cromoteca

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.64%. Comparing base (beeccf4) to head (b8da3ba). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/ts/react-signals/src/FullStackSignal.ts 91.66% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2799      +/-   ##
==========================================
+ Coverage   92.60%   92.64%   +0.03%     
==========================================
  Files          83       83              
  Lines        2812     2840      +28     
  Branches      724      728       +4     
==========================================
+ Hits         2604     2631      +27     
- Misses        156      157       +1     
  Partials       52       52              
Flag Coverage Δ
unittests 92.64% <95.65%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 08 '24 14:10 codecov[bot]

Also ListSignal's operations need another follow-up PR to enable the thenables, right?

taefi avatar Oct 21 '24 09:10 taefi