Use the correct service name

[Legioth]

[CLAassistant]

All committers have signed the CLA.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.60%. Comparing base (52484b9) to head (0638cb8). Report is 13 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2666   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          85       85           
  Lines        3164     3164           
  Branches      775      775           
=======================================
  Hits         2930     2930           
  Misses        183      183           
  Partials       51       51           

Flag	Coverage Δ
unittests	92.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[taefi]

Funny that since we moved to servlet 5, no one complained about this, so either:

• No one is deploying a war package on a servlet container, or
• The com.vaadin.hilla.startup.EndpointsValidator is loaded by Flow automatically since it is implementing com.vaadin.flow.server.startup.ClassLoaderAwareServletContainerInitializer - not sure that's the reason.

Then, the question is: Do we actually need it? Anyway, this change doesn't harm anyone and should have been applied sooner.

[Legioth]

Should maybe also be cherry picked to 24.4.x?

[taefi]

Should maybe also be cherry picked to 24.4.x?

At least to 24.4. 2.5 is also using the jakarta namespace.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cromoteca]

Some of those changes could not propagate well to some of the cherry-pick target that have been selected for this PR.

[cromoteca]

Also, given that it uses a ClassFinder from Flow, it seems to collect all classes annotated with BrowserCallable/Endpoint, but not all classes will be instantiated and used, so it seems a bit too strong as a check.

[taefi]

I'm in favor of logging a warning instead of throwing in EndpointValidator. A visible enough warning + documentation should be enough.

[cromoteca]

I still see this as a sort of duplicate of https://github.com/vaadin/hilla/pull/2938. While they serve different purposes, the check for the presence of Spring could be added at the same place instead of having to declare a dedicated listener.

[cromoteca]

No longer needed after https://github.com/vaadin/hilla/pull/3167