hilla icon indicating copy to clipboard operation
hilla copied to clipboard

fix(bug): Fix form validation does not work in Kotlin.

Open Yue-plus opened this issue 1 year ago • 4 comments

Description

  • -Xjsr305=strict: This argument changes how the Kotlin compiler handles nullability annotations. The strict mode means that the compiler will strictly check nullability annotations and give a warning or error when it finds a problem.
  • -Xemit-jvm-type-annotations: This argument makes the Kotlin compiler emit JVM type annotations into the bytecode.

Fixes #2343

Type of change

  • [x] Bugfix
  • [ ] Feature

Checklist

  • [x] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • [x] I have added a description following the guideline.
  • [x] The issue is created in the corresponding repository and I have referenced it.
  • [x] I have added tests to ensure my change is effective and works as intended.
  • [x] New and existing tests are passing locally with my change.
  • [x] I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • [ ] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Yue-plus avatar Jun 11 '24 01:06 Yue-plus

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 11 '24 01:06 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 11 '24 01:06 CLAassistant

I apologize for my previous misunderstanding of the Groovy programming language. I was not aware that Groovy allows direct assignment to lists without the need to call the addAll method. I have tested these changes locally and confirmed their correctness. Please review this PR again, thank you.

image

Yue-plus avatar Jun 22 '24 20:06 Yue-plus

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.60%. Comparing base (f7b7546) to head (69a524e). Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2529   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          85       85           
  Lines        3164     3164           
  Branches      775      775           
=======================================
  Hits         2930     2930           
  Misses        183      183           
  Partials       51       51           
Flag Coverage Δ
unittests 92.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 10 '25 18:01 codecov[bot]

Thanks again for the idea @Yue-plus.

Upon a closer look, we found an issue with the approach in this PR: the additional arguments are only applied to the Gradle plugin project, but not the users' applications.

Let me close this as obsolete by #3156, which applies the arguments dynamically using reflection with kotlin-reflect.

platosha avatar Jan 14 '25 13:01 platosha