hilla fix: adjust Hilla statistics collection

trafficstars

Description

This adjusts the Hilla statistics gathering based on what's explained in vaadin/platform#6430

Fixes #2129

Type of change

[x] Bugfix
[ ] Feature

Checklist

[ ] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
[ ] I have added a description following the guideline.
[ ] The issue is created in the corresponding repository and I have referenced it.
[ ] I have added tests to ensure my change is effective and works as intended.
[ ] New and existing tests are passing locally with my change.
[ ] I have performed self-review and corrected misspellings.

Apr 24 '24 13:04 taefi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.07%. Comparing base (016abe8) to head (f0e85bf).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
- Coverage   95.11%   95.07%   -0.05%     
==========================================
  Files          66       66              
  Lines        4507     4510       +3     
  Branches      645      646       +1     
==========================================
+ Hits         4287     4288       +1     
- Misses        179      181       +2     
  Partials       41       41

Flag	Coverage Δ
unittests	`95.07% <100.00%> (-0.05%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Apr 24 '24 14:04 codecov[bot]

The description mentions three out of the four potential states of the two booleans. Is there a possibility that the fourth option could ever happen, i.e. FrontendUtils.isReactRouterRequired() == false && deploymentConfiguration.isReactEnabled() == true?