hilla icon indicating copy to clipboard operation
hilla copied to clipboard

fix: use the new default value for frontend/generated

Open taefi opened this issue 1 year ago • 2 comments

Description

Use FrontendUtils.DEFAULT_PROJECT_FRONTEND_GENERATED_DIR instead of the literal value of frontend/generated.

Fixes #2167

Type of change

  • [x] Bugfix
  • [ ] Feature

Checklist

  • [x] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • [x] I have added a description following the guideline.
  • [x] The issue is created in the corresponding repository and I have referenced it.
  • [ ] I have added tests to ensure my change is effective and works as intended.
  • [x] New and existing tests are passing locally with my change.
  • [x] I have performed self-review and corrected misspellings.

taefi avatar Mar 06 '24 11:03 taefi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.77%. Comparing base (dfd2c36) to head (d0acd23).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2180   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files          64       64           
  Lines        1622     1622           
  Branches      364      364           
=======================================
  Hits         1521     1521           
  Misses         66       66           
  Partials       35       35           
Flag Coverage Δ
unittests 93.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 06 '24 11:03 codecov[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 07 '24 07:03 sonarqubecloud[bot]

This ticket/PR has been released with Hilla 24.4.0.alpha11 and is also targeting the upcoming stable 24.4.0 version.

vaadin-bot avatar Mar 11 '24 09:03 vaadin-bot