hilla icon indicating copy to clipboard operation
hilla copied to clipboard

feat: Add VaadinWebSecurity extensions for fs-routing

Open krissvaa opened this issue 11 months ago • 2 comments

Fixes https://github.com/vaadin/hilla/issues/2051

Implement VaadinWebSecurity RouteUtils for spring security route checks based on file-system routing.

If the recent changes are correct, https://github.com/vaadin/flow/pull/18822 is no longer necessary.

Must be activated in Hilla applications by adding:

http.authorizeHttpRequests(authorize -> authorize.requestMatchers(this::isRouteAllowed).permitAll());

to the security configuration (i.e. SecurityConfiguration.java in apps created with @hilla/cli init --auth)

krissvaa avatar Feb 28 '24 10:02 krissvaa

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.77%. Comparing base (7b403ae) to head (1a8a996).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2137   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files          64       64           
  Lines        1622     1622           
  Branches      364      364           
=======================================
  Hits         1521     1521           
  Misses         66       66           
  Partials       35       35           
Flag Coverage Δ
unittests 93.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 29 '24 05:02 codecov[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 08 '24 07:03 sonarqubecloud[bot]

This ticket/PR has been released with Hilla 24.4.0.alpha11 and is also targeting the upcoming stable 24.4.0 version.

vaadin-bot avatar Mar 11 '24 09:03 vaadin-bot