hilla icon indicating copy to clipboard operation
hilla copied to clipboard

chore: remove Lumo / Material class copies

Open platosha opened this issue 1 year ago • 2 comments

Fixes #2058

platosha avatar Feb 22 '24 18:02 platosha

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.11%. Comparing base (ca94fb5) to head (1bf2c70).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2106      +/-   ##
==========================================
+ Coverage   95.09%   95.11%   +0.02%     
==========================================
  Files          66       66              
  Lines        4507     4507              
  Branches      644      645       +1     
==========================================
+ Hits         4286     4287       +1     
+ Misses        180      179       -1     
  Partials       41       41              
Flag Coverage Δ
unittests 95.11% <ø> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 22 '24 18:02 codecov[bot]

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 27 '24 11:02 sonarqubecloud[bot]

Hi @platosha and @Artur-, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick e397dbeb35f5b7a97d24e0ac7b502dbd49f5a8c3 error: could not apply e397dbeb... chore: remove Lumo / Material class copies (#2106) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".

vaadin-bot avatar May 14 '24 11:05 vaadin-bot