framework
framework copied to clipboard
Height of the calendar in monthly view is miscalculated when using Valo theme
Originally by elechim
Hi,
I'm using Vaadin 7.4.6 and I detected a problem with the calendar height when in monthly view.
Setting the height of the calendar ("setHeight("550px")" or "setHeight("100%")") produces the following errors:
- the last week row is not completely visible
- the numers of the weeks (on the left) are not aligned with the rows of the weeks
Setting undefined height works fine.
The problem appears only when using the Valo theme (Reindeer theme works fine).
I tested it with the following UI code:
@Override
protected void init(VaadinRequest request) {
Calendar calendar = new Calendar();
calendar.setLocale(Locale.ENGLISH);
//Load events
setCalendarContainer(calendar);
setCalendarStartEndDate(calendar);
calendar.setWidth("100%");
calendar.setHeightUndefined();_OK
_ calendar.setHeight("550px"); _ERROR
_ calendar.setHeight("100%"); //ERROR
setContent(calendar);
}
And the following custom theme file:
@import "../valo/valo.scss";
@mixin my-theme {
@include valo;
.v-calendar
{
border: 1px solid black;
}
}
Imported from https://dev.vaadin.com/ issue #17954
Originally by elechim
Attachment added: Calendar_reindeer_550px_height.png
(93.4 KiB)
https://trac-attachments.vaadin.com/trac/17954/Calendar_reindeer_550px_height.png
Originally by elechim
Attachment added: Calendar_reindeer_full_height.png
(151.5 KiB)
https://trac-attachments.vaadin.com/trac/17954/Calendar_reindeer_full_height.png
Originally by elechim
Attachment added: Calendar_reindeer_undefined_height.png
(93.3 KiB)
https://trac-attachments.vaadin.com/trac/17954/Calendar_reindeer_undefined_height.png
Originally by elechim
Attachment added: Calendar_valo_500px_height.png
(73.3 KiB)
https://trac-attachments.vaadin.com/trac/17954/Calendar_valo_500px_height.png
Originally by elechim
Attachment added: Calendar_valo_full_height.png
(109.5 KiB)
https://trac-attachments.vaadin.com/trac/17954/Calendar_valo_full_height.png
Originally by elechim
Attachment added: Calendar_valo_undefined_height.png
(72.1 KiB)
https://trac-attachments.vaadin.com/trac/17954/Calendar_valo_undefined_height.png
Hello there!
It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.
There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):
- Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
- Provide more details how to reproduce the issue.
- Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
- Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
- Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
- If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.
Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!
Hello there!
We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.
There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):
- Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
- Provide more details how to reproduce the issue.
- Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
- Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
- Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
- If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.
Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!