framework icon indicating copy to clipboard operation
framework copied to clipboard

Updating bean in Binder clears component error

Open OlliTietavainenVaadin opened this issue 5 years ago • 4 comments

  • Vaadin Framework version 8.5.1

Opposite case of https://github.com/vaadin/framework/issues/11091 : If use setComponentError() to set an error message for a component and then use a binding to update the bean, the error is never shown. It's not strictly speaking a bug, but can be confusing like in #11091 . This could also be documented in JavaDoc, perhaps in Binder::bind.

OlliTietavainenVaadin avatar Aug 31 '18 12:08 OlliTietavainenVaadin

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

stale[bot] avatar Jan 29 '19 10:01 stale[bot]

True. Same holds for as required indicator. When field is used with Binder, one should not directly control these, but let Binder take care of it.

TatuLund avatar Feb 09 '20 16:02 TatuLund

Currently documentation states the following (which covers also this use case, but not explicitly)

https://vaadin.com/docs/v8/framework/datamodel/datamodel-forms.html

The validation state of each field is updated whenever the user modifies the value of that field. The validation state is by default shown using AbstractComponent.setComponentError which is used by the layout that the field is shown in. Whenever an error is set, the component will also get a v--error class name, e.g. v-textfield-error. This error class will by default add a red border on the component. The component will also get a tooltip that shows the error message text.

TatuLund avatar Feb 09 '20 16:02 TatuLund

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

stale[bot] avatar Jul 11 '20 01:07 stale[bot]