chore: Format for Java 17 instead of Java 5

[Artur-]

[github-actions[bot]]

Test Results

1 146 files  ± 0  1 146 suites  ±0   1h 32m 53s ⏱️ -40s 7 489 tests ± 0  7 439 ✅ ± 0  50 💤 ±0  0 ❌ ±0  7 811 runs   - 48  7 753 ✅  - 46  58 💤  - 2  0 ❌ ±0 

Results for commit 09e5d216. ± Comparison against base commit 05f03774.

:recycle: This comment has been updated with latest results.

[Artur-]

Is there something unclear with this? Planning to go back to Java 5? :)

[tepi]

Is there something unclear with this? Planning to go back to Java 5? :)

No plans currently but we can consider if it's requested.

There's some weird formatting in this PR like https://github.com/vaadin/flow/pull/20185/files#diff-47044a537fba8b2a6975f168bad9c93d53b03670a2337d51732880433b5dfbdeR77-R80

Also https://github.com/vaadin/flow/pull/20185/files#diff-c45aec1725063f2febff465083954b8eca10fa2b4e2de26a92ba949d57dfac5cR88-R93 is probably correct but previous version looked more clear, maybe it was not formatted before this PR?

Edit: fixed the first one. Maybe the second one can be left as is.

[Artur-]

Yeah it's not clear why it changes the formatting in the second case you mentioned. The thing it is able to handle when set to Java 17 is records formatting, that is completely broken with Java 5

[sonarqubecloud[bot]]

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[vaadin-bot]

Hi @Artur- and @tepi, when i performed cherry-pick to this commit to 24.5, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick 5891c2c1b65ce579cafcc011f15945fa7f2ab7dc error: could not apply 5891c2c1b6... chore: Format for Java 17 instead of Java 5 (#20185) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".

[vaadin-bot]

Hi @Artur- and @tepi, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick 5891c2c1b65ce579cafcc011f15945fa7f2ab7dc error: could not apply 5891c2c1b6... chore: Format for Java 17 instead of Java 5 (#20185) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".