flow icon indicating copy to clipboard operation
flow copied to clipboard

refactor!: Remove deployment conf field from VaadinSession

Open tepi opened this issue 1 year ago • 5 comments

Fixes #18318

tepi avatar Dec 15 '23 13:12 tepi

Test Results

1 045 files  ±  0  1 045 suites  ±0   1h 14m 19s :stopwatch: + 3m 32s 6 736 tests ±  0  6 691 :heavy_check_mark: +  6  45 :zzz: ±0  0 :x:  - 1  7 036 runs  +28  6 980 :heavy_check_mark: +34  56 :zzz: ±0  0 :x:  - 1 

Results for commit c107a81d. ± Comparison against base commit 757c8cba.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Dec 15 '23 13:12 github-actions[bot]

Some tests to fix, but other than that LGTM

mcollovati avatar Dec 19 '23 10:12 mcollovati

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Dec 19 '23 11:12 sonarqubecloud[bot]

Despite approval, do not merge. This should be postponed until major release of Flow (25), since this changes public API.

tepi avatar Dec 19 '23 12:12 tepi

Would it be better to make it a draft again, to prevent unwanted merge?

mcollovati avatar Dec 19 '23 12:12 mcollovati