flow icon indicating copy to clipboard operation
flow copied to clipboard

URL incorrect after BeforeLeaveEvent.ContinueNavigationAction.proceed()

Open simasch opened this issue 1 year ago • 6 comments

Description of the bug

  1. Start my example
  2. Click on the link "Two"
  3. Then click on the Browser back button and confirm the dialog
  4. Now check the URL and you will see that it's incorrect.

Expected behavior

The URL should be correct

Minimal reproducible example

https://github.com/simasch/vaadin-postpone-navigation

Versions

  • Vaadin / Flow version: 24.1.5
  • Java version: 17

simasch avatar Aug 15 '23 12:08 simasch

Sounds similar to https://github.com/vaadin/flow/issues/9551

knoobie avatar Aug 15 '23 12:08 knoobie

@knoobie Indeed! Wow, this issue is three years old and seems to be inactive.

simasch avatar Aug 15 '23 12:08 simasch

Unfortunately, both Denis + Pekka in the ticket are no longer part of the flow team, therefore it probably slipped through over the years.

knoobie avatar Aug 15 '23 12:08 knoobie

Let's see what happens here ;-)

simasch avatar Aug 15 '23 12:08 simasch

This was working with Vaadin 23.3! So it looks like a regression.

simasch avatar Aug 15 '23 13:08 simasch

This appears to be similar to https://github.com/vaadin/flow/issues/17528, that has been fixed and released in 24.1.11

I think this issue can be closed, since I cannot reproduce it with the latest 24.3 nor with 24.1.11

mcollovati avatar Feb 06 '24 15:02 mcollovati

@mcollovati I think I can reproduce this with 24.4 ;) https://github.com/vaadin/flow/issues/19786

knoobie avatar Aug 14 '24 09:08 knoobie

Tested using Vaadin 24.4.10 (and 24.5-SNAPSHOT as well) and latest available Chrome browser on macOS. Could not reproduce the issue with either react router or vaadin router. URL is correctly updated when clicking the confirm button in the dialog.

tepi avatar Aug 22 '24 07:08 tepi

I'll close this issue for now since it can't be reproduced with latest Vaadin version. Please open a new issue if the problem still persists in some circumstances.

tepi avatar Aug 22 '24 07:08 tepi