flow
flow copied to clipboard
URL incorrect after BeforeLeaveEvent.ContinueNavigationAction.proceed()
Description of the bug
- Start my example
- Click on the link "Two"
- Then click on the Browser back button and confirm the dialog
- Now check the URL and you will see that it's incorrect.
Expected behavior
The URL should be correct
Minimal reproducible example
https://github.com/simasch/vaadin-postpone-navigation
Versions
- Vaadin / Flow version: 24.1.5
- Java version: 17
Sounds similar to https://github.com/vaadin/flow/issues/9551
@knoobie Indeed! Wow, this issue is three years old and seems to be inactive.
Unfortunately, both Denis + Pekka in the ticket are no longer part of the flow team, therefore it probably slipped through over the years.
Let's see what happens here ;-)
This was working with Vaadin 23.3! So it looks like a regression.
This appears to be similar to https://github.com/vaadin/flow/issues/17528, that has been fixed and released in 24.1.11
I think this issue can be closed, since I cannot reproduce it with the latest 24.3 nor with 24.1.11
@mcollovati I think I can reproduce this with 24.4 ;) https://github.com/vaadin/flow/issues/19786
Tested using Vaadin 24.4.10 (and 24.5-SNAPSHOT as well) and latest available Chrome browser on macOS. Could not reproduce the issue with either react router or vaadin router. URL is correctly updated when clicking the confirm button in the dialog.
I'll close this issue for now since it can't be reproduced with latest Vaadin version. Please open a new issue if the problem still persists in some circumstances.