flow icon indicating copy to clipboard operation
flow copied to clipboard

Published 20 hours ago • verified publisher icon vaadin

DataSerializableTest.selfReferenceSerialization does not test the fix it was added for

Open tepi opened this issue 1 year ago • 0 comments

Description of the bug

The test added to DataSerializableTest class in the commit https://github.com/vaadin/flow/pull/6845/files seems to pass regardless of the actual fix being present or not, so looks like it does not actually test the fix in question.

Expected behavior

I would expect the test to fail one I revert the fix to AbstractDataProvider.

Minimal reproducible example

  1. Check out flow master branch
  2. Remove the fix (https://github.com/vaadin/flow/pull/6845/files) from AbstractDataProvider
  3. Run DataSerializableTest

Versions

  • Vaadin / Flow version: snapshot from master branch
  • Java version: openjdk 17.0.2 2022-01-18 LTS
  • OS version: macOS 12.3.1

tepi avatar Oct 14 '22 12:10 tepi