flow icon indicating copy to clipboard operation
flow copied to clipboard

fix: use access and not lock

Open caalador opened this issue 3 years ago • 2 comments

Use access so that we do not block with the lock

Fixes vaadin/multiplatform-runtime#101

caalador avatar Oct 13 '22 11:10 caalador

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 13 '22 11:10 sonarqubecloud[bot]

Unit Test Results

   956 files  ±0     956 suites  ±0   49m 13s :stopwatch: - 7m 51s 6 085 tests ±0  6 031 :heavy_check_mark: ±0  54 :zzz: ±0  0 :x: ±0  6 348 runs   - 2  6 286 :heavy_check_mark:  - 2  62 :zzz: ±0  0 :x: ±0 

Results for commit d8fca9bc. ± Comparison against base commit 62f9b4f4.

github-actions[bot] avatar Oct 13 '22 12:10 github-actions[bot]

Hi @caalador and @caalador, when i performed cherry-pick to this commit to 2.8, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick 1b6fc69c2809c65f0e837e1cac2da1e119a067bb error: could not apply 1b6fc69c28... fix: use access and not lock (#14827) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".

vaadin-bot avatar Oct 18 '22 12:10 vaadin-bot

Hi @caalador and @caalador, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick 1b6fc69c2809c65f0e837e1cac2da1e119a067bb error: could not apply 1b6fc69c28... fix: use access and not lock (#14827) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".

vaadin-bot avatar Oct 18 '22 12:10 vaadin-bot

This causes https://github.com/vaadin/flow/issues/14950 because VaadinSession.getSession() does not return null even though the HTTP session has been invalidated

Artur- avatar Oct 30 '22 14:10 Artur-