flow icon indicating copy to clipboard operation
flow copied to clipboard

Published 20 hours ago • verified publisher icon vaadin

Commenting @import in styles.css gives net::ERR_ABORTED 404

Open sveine opened this issue 2 years ago • 1 comments

Description of the bug

image

(File exists on disk)

image

Expected behavior

Parser should ignore everything in comments

Minimal reproducible example

/*@import "my-style.css";*/

Versions

Hilla: 23.2.3 Flow: 23.2.3 Java: JetBrains s.r.o. 17.0.2 OS: amd64 Windows 10 10.0 Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36 Live reload: Java active (HotswapAgent): Front end active

sveine avatar Oct 07 '22 09:10 sveine

This is a problem in https://github.com/vaadin/flow/blob/e4f7e1024b9828092408060d8b4e192a03d97d83/flow-server/src/main/resources/plugins/application-theme-plugin/theme-generator.js#L37-L72 which does not at all consider that imports can be commented out

Artur- avatar Oct 07 '22 13:10 Artur-

This ticket/PR has been released with Vaadin 23.1.14.

vaadin-bot avatar Nov 07 '22 10:11 vaadin-bot

This ticket/PR has been released with Vaadin 23.2.7.

vaadin-bot avatar Nov 08 '22 06:11 vaadin-bot